[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform
Chris Ball
cjb at laptop.org
Sat Oct 26 22:28:19 EDT 2013
Hi Zhangfei, just small changes,
On Wed, Oct 23 2013, Zhangfei Gao wrote:
> +* tune-table: should be array of clock tune mmc controller
This sounds like it should be "tuning-table", and shouldn't it also
have a prefix?
> + node = of_find_compatible_node(NULL, NULL,
> + "hisilicon,pctrl");
No need to use two lines here.
> + ret = of_property_read_u32_array(np,
> + "clken-reg", data, 2);
Or here, same with the other of_property_read_u32_array() calls.
> +MODULE_DESCRIPTION("K3 Specific DW-MSHC Driver Extension");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:dwmmc-k3");
Can you add a MODULE_AUTHOR too?
Thanks,
- Chris.
--
Chris Ball <cjb at laptop.org> <http://printf.net/>
More information about the linux-arm-kernel
mailing list