[PATCH RFC v2 3/4] net: mvmdio: slight optimisation of orion_mdio_write
David Miller
davem at davemloft.net
Sat Oct 26 01:45:45 EDT 2013
From: Leigh Brown <leigh at solinno.co.uk>
Date: Thu, 24 Oct 2013 19:09:33 +0100
> Make only a single call to mutex_unlock in orion_mdio_write.
>
> Signed-off-by: Leigh Brown <leigh at solinno.co.uk>
You patch does more than what you're talking about here in your
commit message. In particular you're also changing the interpretation
of the orion_mdio_wait_ready() return value by changing the test
from < 0 to != 0.
Even if that is a legitimate change:
1) You're not describing it in the commit message at all.
2) It's a logically separate change, so should go into a completely
separate patch.
More information about the linux-arm-kernel
mailing list