[PATCH 1/4] cpufreq: Add a cpufreq driver for Marvell Dove

Viresh Kumar viresh.kumar at linaro.org
Wed Oct 23 10:25:12 EDT 2013


On 23 October 2013 19:21, Andrew Lunn <andrew at lunn.ch> wrote:
> There does seem to be a convention that kernel.h and module.h come
> first, and then i have the rest in order.

Atleast I am not aware of any such convention and so got
confused.

> +/*
> + * Handle the interrupt raised when the frequency change is
> + * complete.
> + */
> +static irqreturn_t dove_cpufreq_irq(int irq, void *dev)
> +{
> +       return IRQ_HANDLED;
> +}
>
> What more would you like to see in the comment?

Ahh.. I read it as "Commented interrupt handler and so it is no
more registered" :)

So, you have actually tested your code without interrupt handler?
What exactly happens in that case?



More information about the linux-arm-kernel mailing list