[PATCH v2] clk: armada-370: fix tclk frequencies

Mike Turquette mturquette at linaro.org
Wed Oct 23 06:45:34 EDT 2013


Quoting Jason Cooper (2013-10-17 05:31:59)
> Mike,
> 
> I going to go ahead a take this through my tree.  I'll hold it off until
> my last pull request for the merge window (I'm guessing about a week).
> If you object, just let me know before then and I'll drop it.
> 
> 
> On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote:
> > This patch fixes the tclk frequency array for the Armada-370 SoC.
> > This bug has been introduced by commit 6b72333d
> > ("clk: mvebu: add Armada 370 SoC-centric clock init").
> > 
> > A wrong tclk frequency affects the following drivers: mvsdio, mvneta,
> > i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
> > 
> > About the mvneta Ethernet driver, note that the tclk frequency is used
> > to compute the Rx time coalescence. Then, this bug harms the coalescence
> > configuration and also degrades the networking performances with the
> > default values.
> > 
> > Signed-off-by: Simon Guinot <simon.guinot at sequanux.org>
> > Cc: Andrew Lunn <andrew at lunn.ch>
> > Cc: Gregory CLEMENT <gregory.clement at free-electrons.com>
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
> > Cc: Jason Cooper <jason at lakedaemon.net>
> > Cc: stable at vger.kernel.org
> > ---
> >  drivers/clk/mvebu/armada-370.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied to mvebu/drivers for v3.13 and flagged for stable going back to
> v3.11.  Also added Gregory's Ack.

Worked it out with Jason face to face. I've added to clk-fixes with ACKs
and will send out this week.

Regards,
Mike

> 
> thx,
> 
> Jason.



More information about the linux-arm-kernel mailing list