[Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property
Peter Chen
peter.chen at freescale.com
Wed Oct 23 02:49:36 EDT 2013
On Wed, Oct 23, 2013 at 02:31:56PM +0800, Shawn Guo wrote:
> On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote:
> > This property is used to disconnect line between USB PHY and
> > USB controller.
> >
> > Signed-off-by: Peter Chen <peter.chen at freescale.com>
> > ---
> > Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > index 5837963..356c9b6 100644
> > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > @@ -9,6 +9,9 @@ mxs PHY verions.
> > - reg: Should contain registers location and length
> > - interrupts: Should contain phy interrupt
> > - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial
> > +- disconnect-line-without-vbus: needs to disconnect
> > +connection between USB PHY and controller, it can avoid
> > +unexpected wakeup interrupt when the PHY is out of power
>
> If it's a mxs-phy specific property, we may need to have vendor prefix
> 'fsl,' for it.
It is mx6 version mxs-phy specific, I will add prefix "imx6"
>
> I see you set the property in imx6qdl.dtsi. Is it true that we should
> always set it for imx6q/dl? If yes, why cannot we have the driver to
> force it for imx6q type of phy. If no, where do we need to set it and
> where not?
>
Yes, it is needed for current imx6dq, imx6dl, and imx6sl SoC.
--
Best Regards,
Peter Chen
More information about the linux-arm-kernel
mailing list