[PATCHv4][ 1/4] Input: tsc2007: Add device tree support.
Dmitry Torokhov
dmitry.torokhov at gmail.com
Mon Oct 21 11:59:27 EDT 2013
Hi Denis,
On Mon, Oct 21, 2013 at 03:54:24PM +0200, Denis Carikli wrote:
>
> + if (ts->of)
> + return tsc2007_get_pendown_state_dt(ts);
> +
> if (!ts->get_pendown_state)
> return true;
Instead of special casing "if (ts->of)" all over the place why don't you
set up the device structure as:
if (<configuring_tsc2007_form_dt>)
ts->get_pendown_state = tsc2007_get_pendown_state_dt;
and be done with it?
Thanks.
--
Dmitry
More information about the linux-arm-kernel
mailing list