[PATCH] ASoC: kirkwood: cleanup the external clock probe

Jean-Francois Moine moinejf at free.fr
Mon Oct 21 06:09:16 EDT 2013


On Mon, 21 Oct 2013 09:52:00 +0100
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:

> > > NAK.  It can occur.  
> > 
> > In which case? And, what would be the right treatment?  
> 
>         priv->clk = devm_clk_get(&pdev->dev, NULL);
>         priv->extclk = devm_clk_get(&pdev->dev, "extclk");
> 
> Supplying the first clock to this driver without a separate "extclk"
> via clkdev will return it as the second clock.
> 
> Again, NAK.  Your change is against the principles of the clk API.

You are right.

Mark, please forget about this patch.

Thanks.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/



More information about the linux-arm-kernel mailing list