[PATCH] genirq: error reporting for non-percpu interrupt in request_percpu_irq()

Vinayak Kale vkale at apm.com
Fri Oct 18 06:09:08 EDT 2013


Need for this patch is discussed in mail-thread [1].

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/204414.html

Thanks
-Vinayak

On Fri, Oct 18, 2013 at 3:36 PM, Vinayak Kale <vkale at apm.com> wrote:
> Return a separate error code when a non-percpu interrupt is passed to
> request_percpu_irq().
>
> Suggested-by: Will Deacon <will.deacon at arm.com>
> Signed-off-by: Vinayak Kale <vkale at apm.com>
> ---
>  kernel/irq/manage.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 514bcfd..c2713ae 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1671,10 +1671,12 @@ int request_percpu_irq(unsigned int irq, irq_handler_t handler,
>                 return -EINVAL;
>
>         desc = irq_to_desc(irq);
> -       if (!desc || !irq_settings_can_request(desc) ||
> -           !irq_settings_is_per_cpu_devid(desc))
> +       if (!desc || !irq_settings_can_request(desc))
>                 return -EINVAL;
>
> +       if (!irq_settings_is_per_cpu_devid(desc))
> +               return -EPERM;
> +
>         action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);
>         if (!action)
>                 return -ENOMEM;
> --
> 1.7.9.5
>



More information about the linux-arm-kernel mailing list