[PATCH v2 1/5] pinctrl: rockchip: separate different sub-types more

Linus Walleij linus.walleij at linaro.org
Wed Oct 16 07:40:58 EDT 2013


On Wed, Oct 16, 2013 at 1:07 AM, Heiko Stübner <heiko at sntech.de> wrote:

> Further investigation of the different Rockchip SoCs showed that
> the differences especially in the pull settings are quite deep.
> As further patches will show, the register layout for the pulls of
> the rk3188 is quite strange. Also it is to assume, that later
> Rockchip SoCs may introduce even more quirks in this regard, making
> it hard to support all of those using the current generic pull_*
> variables.
>
> Therefore move the driver to hold the type of controller in an enum
> and do the handling according to it in the necessary places. Also
> instead of calculating the register in the get and set pull functions
> move it to a type-specific callback.
>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>

Patch applied.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list