[PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

Fabio Estevam festevam at gmail.com
Tue Oct 15 09:17:07 EDT 2013


On Tue, Oct 15, 2013 at 10:10 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> Another point on patch 1.  Sorry, I don't have patch 1 to reply to, it
> seems it was deleted from linux-arm-kernel's moderation queue.
>
> drm_mode_connector_attach_encoder() is called too early, before the
> base.id field in the encoder has been initialised.  This causes the
> connectors encoder array to be empty, and userspace KMS to fail.
>
> There's also bugs in the CSC setting too - it runs off the end of the
> array and gcc warns about this.  The code was clearly wrong.
>
> You may wish to combine this patch with patch 1 to sort all that out.
> For the patch below:
>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> Tested-by: Russell King <rmk+kernel at arm.linux.org.uk>

Thanks, Russell.

Will submit v3 when I am back to the office.

Regards,

Fabio Estevam



More information about the linux-arm-kernel mailing list