[PATCH v3 05/14] ARM: mvebu: Make ll_set_cpu_coherent() more configurable

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Oct 14 10:26:36 EDT 2013

Dear Gregory CLEMENT,

On Mon, 14 Oct 2013 15:58:17 +0200, Gregory CLEMENT wrote:
> ll_set_cpu_coherent does two things to set the coherency for a CPU:
> - Adding the CPU to the SMP group 0
> - Enabling the snooping on the CPU
> Only the second part is needed when coming back from a CPU Idle. This
> commit allows to choose to do the first part or not.

I am not a fan of this change: those two boolean arguments are really
mystical. If a function does do things, and sometimes must be called to
do one thing, and sometimes for two things, it is really calling for a
split of the functions (with potentially the second function calling the
first, or the two functions being called in a row when needed).

Let's have two functions:


at initialization time, both functions are called. On the exit path of
idle, only the second one is called.

Best regards,

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering

More information about the linux-arm-kernel mailing list