[PATCH v3 3/3] ARM: add support for bit sliced AES using NEON instructions

Herbert Xu herbert at gondor.apana.org.au
Mon Oct 14 07:29:21 EDT 2013


On Sun, Oct 13, 2013 at 12:30:49PM +0100, Russell King - ARM Linux wrote:
> On Sun, Oct 13, 2013 at 01:28:01PM +0200, Ard Biesheuvel wrote:
> > On 13 October 2013 13:22, Russell King - ARM Linux
> > <linux at arm.linux.org.uk> wrote:
> > > On Sun, Oct 13, 2013 at 01:19:29PM +0200, Ard Biesheuvel wrote:
> > >> On 13 October 2013 13:14, Russell King - ARM Linux
> > >> <linux at arm.linux.org.uk> wrote:
> > >> > On Sun, Oct 13, 2013 at 12:21:49PM +0200, Ard Biesheuvel wrote:
> > >> >> On 13 October 2013 12:03, Russell King - ARM Linux
> > >> >> <linux at arm.linux.org.uk> wrote:
> > >> >> > On Fri, Oct 04, 2013 at 09:03:39PM +0200, Ard Biesheuvel wrote:
> > >> >>
> > >> >> [...]
> > >> >>
> > >> >> >> +#include <asm/neon.h>
> > >> >> >> +#include <crypto/aes.h>
> > >> >> >> +#include <crypto/ablk_helper.h>
> > >> >> >
> > >> >> > This header file doesn't appear to exist, and so causes this build error:
> > >> >> >
> > >> >>
> > >> >> Hi Russell,
> > >> >>
> > >> >> This is expected.
> > >> >>
> > >> >> Perhaps I should have addressed this differently, but I had put the
> > >> >> following in my pull request
> > >> >>
> > >> >> !! NOTE !!: this series build-depends on patch a62b01cd (crypto: create generic
> > >> >> version of ablk_helper) which is in linux-next but not yet in mainline.
> > >> >>
> > >> >> expecting you to either defer pulling it or handle the
> > >> >> cross-dependency in some other way.
> > >> >
> > >> > Where can I find that commit?
> > >>
> > >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/crypto?id=a62b01cd6cc1feb5e80d64d6937c291473ed82cb
> > >
> > > I need a git tree I can pull with this commit in (and preferably without
> > > much in the way of dependencies.)  Commits in linux-next are not deemed
> > > to be stable.
> > 
> > This one perhaps?
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=a62b01cd6cc1feb5e80d64d6937c291473ed82cb
> > 
> > Unfortunately, it has a string of unrelated commits between this one
> > and the first one already appearing in mainline.
> > However, as it originates in Herbert's tree (including Herbert's
> > signoff) and it mostly only adds files, cherry-picking should be
> > relatively trouble free in this case (if that is an option at all)
> 
> Herbert,
> 
> Could I have a git URL to pull the above commit please?

Russell, do you want me to revert this patch from cryptodev?
Otherwise I'm not quite sure what you want me to do here.

Cheers,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list