[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Peter De Schrijver]

On Thu, Oct 10, 2013 at 06:07:38PM +0200, Stephen Warren wrote:
> On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> > On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
> >> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
> >>> Local variables used only in this file are made static.
> >>
> > 
> > Conceptually they are still exported. So I think it's counterintuitive to
> > declare them static. Unless you expect namespace problems, I would rather
> > leave it as is.
> 
> I forget exactly which symbols this patch changed, but presumably
> they're only exported via pointers rather than by symbol name, and isn't
> that exactly what static is for?

They are indeed exported using a pointer. depends on how you look at it I
guess, but I see static as 'local to this file only' which isn't really
true if you hand out pointers to others.

Cheers,

Peter.