[PATCH 3/4] ARM: tegra: make tegra_resume can work with current and later chips
Joseph Lo
josephl at nvidia.com
Wed Oct 9 04:23:22 EDT 2013
On Wed, 2013-10-09 at 11:11 +0800, Joseph Lo wrote:
> On Wed, 2013-10-09 at 01:00 +0800, Stephen Warren wrote:
> > On 10/08/2013 02:23 AM, Joseph Lo wrote:
> > > diff --git a/arch/arm/mach-tegra/reset-handler.S b/arch/arm/mach-tegra/reset-handler.S
> >
> > > not_ca9:
> > > + mov32 r9, 0xc0f
> > > + cmp r8, r9
> > > + bleq tegra_init_l2_for_a15
> >
> > That's checking whether the CPU type is a Cortex-A15, isn't it? The only
> > CPUs that exist NVIDIA SoCs are Cortex-A9 and Cortex-A15, so I don't see
> > why we need to check whether the CPU is a Cortex-A15, given this label
> > is jumped to only when the CPU isn't a Cortex-A9.
>
> Good catch. Will fix.
>
Ah! I just realize the Cortex-A9 will go through here as well. So I
still need to code to make sure only Cortex-A15 execute the function.
More information about the linux-arm-kernel
mailing list