[PATCH v2] ARM: tlb: ASID macro should give 32bit result for BE correct operation

Victor Kamensky victor.kamensky at linaro.org
Mon Oct 7 12:19:17 EDT 2013


On 7 October 2013 08:52, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Mon, Oct 07, 2013 at 08:48:23AM -0700, Victor Kamensky wrote:
>> -#define ASID(mm)     ((mm)->context.id.counter & ~ASID_MASK)
>> +#define ASID(mm)     ((unsigned int)((mm)->context.id.counter & ~ASID_MASK))
>
> Not a big problem, but "unsigned" is sufficient as per my suggestion.
> See:
>
>         http://en.wikipedia.org/wiki/C_data_types
>
> or look it up in the C standards. :)  I'll take it either way.

Understood, I just tried to be consistent with the rest of file -
'unsigned int' was
used just few lines above place that got changed.

Thanks,
Victor



More information about the linux-arm-kernel mailing list