[RFC PATCH] ARM: Flush L2 cache on soft_restart

[Will Deacon]

On Wed, Oct 02, 2013 at 06:19:30PM +0100, Taras Kondratiuk wrote:
> On 2 October 2013 15:49, Will Deacon <will.deacon at arm.com> wrote:
> > On Wed, Oct 02, 2013 at 12:34:16PM +0100, Taras Kondratiuk wrote:
> >> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> >> index 94f6b05..e359b62 100644
> >> --- a/arch/arm/kernel/process.c
> >> +++ b/arch/arm/kernel/process.c
> >> @@ -103,9 +103,11 @@ void soft_restart(unsigned long addr)
> >>       local_irq_disable();
> >>       local_fiq_disable();
> >>
> >> -     /* Disable the L2 if we're the last man standing. */
> >> -     if (num_online_cpus() == 1)
> >> +     /* Flush and disable the L2 if we're the last man standing. */
> >> +     if (num_online_cpus() == 1) {
> >> +             outer_flush_all();
> >>               outer_disable();
> >
> > l2x0_disable already contains a flush, so this doesn't change anything.
> 
> Unfortunately not everybody uses l2x0_disable().
> SoC's that use SMC calls for L2 cache maintenance have its own implementation
> of outer_cache.disable which usually doesn't flush cache implicitly.

In which case, we should probably fix the disabling code to make a flush
then update callers not to bother with redundant flushing. The flushing
during the disable code is likely required anyway if there's any
synchronisation going on.

Will