[PATCH 01/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear

[Jason Cooper]

Ezequiel,

On Wed, Aug 28, 2013 at 10:33:34AM -0600, Jason Gunthorpe wrote:
> On Wed, Aug 28, 2013 at 09:08:02AM -0300, Ezequiel Garcia wrote:
> 
> > Hm.. but in order to make this work, we need the bridge interrupt
> > controller introduced by Sebastian, but not available in the "older"
> > platforms (right?).
> 
> TBH, I'm not sure of the state of this - I thought the last patches I
> saw covered everything (though perhaps DT bindings are needed for some
> platforms)?
> 
> Some platforms don't have a bridge cause register, the WDT comes
> directly off the main interrupt controller and the write to a 'bridge
> cause regsiter' in the wdt driver is already completely bogus. This is
> why the irq chip driver needs to take care of this.
> 
> > So, in order to add support to Armada 370/XP watchdog (which was the
> > initial goal of all of this) I think our sane option reduce to two:
> > 
> > * Drop watchdog support on non-DT platforms and add support for
> >   A370/XP in the orion-wdt driver.
> >   I don't quite like the idea of dropping support on anything,
> >   so I can't say I'm thrilled by this idea.
> 
> Well, can you pass all the register addresess and interrupts in
> through platform_data on these unconverted boards?
> 
> Maybe a config switch 'CONFIG_ARMADA_WATCHDOG_SINGLE_PLATFORM' to
> enable the old behavior and include the mach headers, otherwise the
> driver is multiplatform and DT only?
> 
> But I don't see alot of value in doing this work, since I doubt anyone
> will ever use it :(
> 
> > * Support A370/AXP in a different and new armada-wdt driver.
> >   The differences between the SoC might be small, but maybe
> >   enough to justify a separate driver and avoid more problems.
> 
> But A370/AXP isn't really different, it just doesn't have to be
> compatible with boards that haven't finished DT conversion..

Have you made any progress on this?  I know you've been working on other
stuff lately, I just saw this series sitting on my stack and thought I'd
poke you.

thx,

Jason.