[PATCH] clocksource: dw_apb_timer_of: Mark a few more functions as __init

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Oct 1 05:11:01 EDT 2013


Hello Baruch,

On Tue, Oct 01, 2013 at 12:01:08PM +0300, Baruch Siach wrote:
> On Tue, Oct 01, 2013 at 10:38:12AM +0200, Uwe Kleine-König wrote:
> > These are all only called by dw_apb_timer_init which is an __init
> > function, too
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > ---
> >  drivers/clocksource/dw_apb_timer_of.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
> > index 4cbae4f..993cdde 100644
> > --- a/drivers/clocksource/dw_apb_timer_of.c
> > +++ b/drivers/clocksource/dw_apb_timer_of.c
> > @@ -23,7 +23,7 @@
> >  #include <linux/clk.h>
> >  #include <linux/sched_clock.h>
> >  
> > -static void timer_get_base_and_rate(struct device_node *np,
> > +static void __init timer_get_base_and_rate(struct device_node *np,
> >  				    void __iomem **base, u32 *rate)
> >  {
> >  	struct clk *timer_clk;
> > @@ -55,11 +55,11 @@ static void timer_get_base_and_rate(struct device_node *np,
> >  
> >  try_clock_freq:
> >  	if (of_property_read_u32(np, "clock-freq", rate) &&
> > -		of_property_read_u32(np, "clock-frequency", rate))
> > +	    of_property_read_u32(np, "clock-frequency", rate))
> 
> Unintended whitespace change?
Well no, it was intended and I wanted to mention it in the commit log,
but forgot about it. It read:

	if (something &&
		somethingelse)
		dosomething;

which is hard to read.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list