[PATCH 3/3] ARM: dts: Enable ahci sata and sata phy

Sachin Kamat sachin.kamat at linaro.org
Tue Oct 1 02:46:55 EDT 2013


Hi Yuvaraj,

On 1 October 2013 12:03, Yuvaraj Kumar C D <yuvaraj.cd at gmail.com> wrote:
> This patch adds dt entry for ahci sata controller and its
> corresponding phy controller.phy node has been added w.r.t
> new generic phy framework.

[snip]
> +
> +               sata-phy {

Shouldn't this be sata-phy at 38?

> +                       compatible = "sata-phy-i2c";
> +                       reg = <0x38>;
> +               };

[snip]
> -       sata-phy at 12170000 {
> -               compatible = "samsung,exynos5-sata-phy";
> +       sata_phy:sata-phy at 12170000 {

nit: A space after sata_phy: would be good.


-- 
With warm regards,
Sachin



More information about the linux-arm-kernel mailing list