[PATCH 8/8] ARM: ux500: move cpuidle drivers to drivers/cpuidle/
arnd at arndb.de
Wed Jun 26 17:28:27 EDT 2013
On Wednesday 26 June 2013, Linus Walleij wrote:
> On Wed, Jun 26, 2013 at 12:15 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie at samsung.com> wrote:
> --- a/arch/arm/mach-ux500/cpuidle
> -#include "db8500-regs.h"
> -#include "id.h"
> > +++ b/drivers/cpuidle/cpuidle-ux500.c
> > +#include "../../arch/arm/mach-ux500/db8500-regs.h"
> > +#include "../../arch/arm/mach-ux500/id.h"
> Well that was creative. NACK.
> If you want to move the driver you need to come up with
> proper interfaces making the move clean, not just move the files
> and make them compile somewhere else I think.
Seconded. Moving the code into drivers/cpuidle/ doesn't actually
turn it into a proper driver. If we cannot find a way to make these
look like drivers, we shouldn't move them.
More information about the linux-arm-kernel