[PATCH 1/3] clk: Add APM X-Gene SoC clock driver for reference, PLL, and device clocks.

[Loc Ho]

Hi,

I will fix them. With regard to continue where the CSR is NULL, it is
possible to continue as long as both is NOT NULL.

> Use of_iomap(np, 0) here.
>
>> +       } else {
>> +               parameters.csr_reg = NULL;
>> +       }
>
> Are you able to continue if this is the case?
>
>> +
>> +       rc = of_address_to_resource(np, 1, &res);
>> +       if (rc != 0) {
>> +               pr_err("no DTS DIV register for %s\n", np->full_name);
>> +               return;
>> +       }
>> +       if (resource_size(&res)) {
>> +               parameters.divider_reg = ioremap(res.start,
>> +                                               resource_size(&res));
>> +               if (parameters.divider_reg == NULL) {
>> +                       pr_err("Unable to map DIV register for %s\n",
>> +                               np->full_name);
>> +                       if (parameters.csr_reg)
>> +                               iounmap(parameters.csr_reg);
>> +                       return;
>> +               }
>
> Use of_iomap(np, 1) here.
>
>> +       } else {
>> +               parameters.divider_reg = NULL;
>> +       }
>
> Similarly, are you able to continue with this being the case?

-Loc