[PATCH 2/2] ARM: dts: mx28: Fix sgtl5000 codec probe

Shawn Guo shawn.guo at linaro.org
Mon Jun 24 03:29:09 EDT 2013


On Sat, Jun 22, 2013 at 11:04:41AM -0300, Fabio Estevam wrote:
> On Sat, Jun 22, 2013 at 10:24 AM, Marek Vasut <marex at denx.de> wrote:
> 
> > Yuck, I see. This is really ugly :(
> >
> > Just an idea here, can we not maybe defer the SGTL5000 I2C probe?
> 
> This was already discussed in the alsa-devel list, and the
> recommendation was that sgtl5000 should acquire its clock in i2c
> probe.

Yes, we should have sgtl5000 acquire its clock, but when it fails to do
so, there is nothing wrong with deferring it to see if mxs-saif would
provide the clock later.

That said, I do not like the patch, and we should try to have mxs-saif
driver implement and register the clock.

Shawn




More information about the linux-arm-kernel mailing list