[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Markus Pargmann]

On Fri, Jun 21, 2013 at 09:47:40AM +0100, Lorenzo Pieralisi wrote:
> On Fri, Jun 21, 2013 at 06:23:46AM +0100, Shawn Guo wrote:
> > On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote:
> > > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> > > > > +	cpus {
> > > > > +		#size-cells = <0>;
> > > > > +		#address-cells = <1>;
> > > > > +
> > > > > +		cpu at 0 {
> > > > > +			device_type = "cpu";
> > > > > +			compatible = "fsl,imx27", "arm,arm926ejs";
> > > > 
> > > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
> > > > should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
> > > > "imx27" is a SoC name not cpu core.
> > > 
> > > I think Markus take this ARM property from one of existing DTS.
> > > 
> > > shc at shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi
> > > at91sam9260.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9263.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9g45.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9n12.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9x5.dtsi:                        compatible = "arm,arm926ejs";
> > > imx23.dtsi:                     compatible = "arm,arm926ejs";
> > > imx28.dtsi:                     compatible = "arm,arm926ejs";
> > > lpc32xx.dtsi:                   compatible = "arm,arm926ejs";
> > > s3c2416.dtsi:                   compatible = "arm,arm926ejs";
> > > spear3xx.dtsi:                  compatible = "arm,arm926ejs";
> > > spear600.dtsi:                  compatible = "arm,arm926ejs";
> > > wm8505.dtsi:                    compatible = "arm,arm926ejs";
> > > 
> > > So, documentation need to be updated or these values should be fixed.
> > > Another solution  is specify compatible string as:
> > > compatible = "arm,arm926ejs", "arm,arm926";
> > > What you think about this?
> > 
> > I assume that the compatible string in the binding doc has been reviewed
> > and agreed by people, so we should fix the existing users before kernel
> > starts using it to for matching something.
> > 
> > Lorenzo, comment?
> 
> I patched them all and changes are queued through arm-soc, according to the
> latest bindings that should get merged this cycle and are available here:
> 
> git://linux-arm.org/linux-2.6-lp.git dt-cpus-bindings
> 
> If you are queuing dts updates please follow rules in there, waiting for
> that document to get merged.
> 
> Lorenzo
> 

Okay, I changed it to "arm,arm926ej-s" and removed "reg" as described in
the dt-cpus-bindings branch documentation.

Thanks,

Markus

> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |