[PATCH v7] ARM PJ4B: Add support for errata 4742

Willy Tarreau w at 1wt.eu
Sun Jun 23 03:20:58 EDT 2013


On Sat, Jun 22, 2013 at 05:51:03PM +0200, Willy Tarreau wrote:
> On Sat, Jun 22, 2013 at 12:44:22PM -0300, Ezequiel Garcia wrote:
> > Hi Greg,
> > 
> > On Fri, Jun 21, 2013 at 05:31:04PM +0200, Gregory CLEMENT wrote:
> > > This commit fixes the regression on Armada 370 (the kernal hang during
> > > boot) introduced by the commit: "ARM: 7691/1: mm: kill unused
> > > TLB_CAN_READ_FROM_L1_CACHE and use ALT_SMP instead".
> > > 
> > > When coming out of either a Wait for Interrupt (WFI) or a Wait for
> > > Event (WFE) IDLE states, a specific timing sensitivity exists between
> > > the retiring WFI/WFE instructions and the newly issued subsequent
> > > instructions. This sensitivity can result in a CPU hang scenario.  The
> > > workaround is to insert either a Data Synchronization Barrier (DSB) or
> > > Data Memory Barrier (DMB) command immediately after the WFI/WFE
> > > instruction.
> > > 
> > > This commit was based on the work of Lior Amsalem, but heavily
> > > modified to apply the errata fix dynamically according to the
> > > processor type thanks to the suggestions of Russell King and Nicolas
> > > Pitre.
> > >
> > > Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> > > Reviewed-by: Will Deacon <will.deacon at arm.com>
> > > Cc: <stable at vger.kernel.org>
> > 
> > This patch doesn't seem to apply on any 3.10-rcX;
> > maybe I'm doing something wrong, but could you double-check this?
> 
> Interesting, I had the same issue and thought it was because of my
> tree, though visually I couldn't spot the issue. It probably was a
> space/tab issue only.

OK it was probably because of other pending changes since rc6, because
it applied perfectly on top of 3.10-rc7.

Willy




More information about the linux-arm-kernel mailing list