[PATCH V4 08/11] USB: OHCI: Properly handle ohci-platform suspend

Manjunath Goudar manjunath.goudar at linaro.org
Thu Jun 20 05:36:04 EDT 2013

Suspend scenario in case of ohci-platform glue was not
properly handled as it was not suspending generic part
of ohci controller. Calling explicitly the ohci_suspend()
routine in ohci_platform_suspend() will ensure proper
handling of suspend scenario.

Signed-off-by: Manjunath Goudar <manjunath.goudar at linaro.org>
Cc: Arnd Bergmann <arnd at arndb.de>
Cc: Alan Stern <stern at rowland.harvard.edu>
Cc: Greg KH <greg at kroah.com>
Cc: linux-usb at vger.kernel.org

 -Incase ohci_suspend() fails, return right away without
  executing further.

 -Aligned variable "do_wakeup" and "ret".

 -The do_wakeup and ret variable alignment is removed.
 drivers/usb/host/ohci-platform.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index bc30475..b4a8784 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -139,14 +139,21 @@ static int ohci_platform_remove(struct platform_device *dev)
 static int ohci_platform_suspend(struct device *dev)
+	struct usb_hcd *hcd = dev_get_drvdata(dev);
 	struct usb_ohci_pdata *pdata = dev->platform_data;
 	struct platform_device *pdev =
 		container_of(dev, struct platform_device, dev);
+	bool do_wakeup = device_may_wakeup(dev);
+	int ret;
+	ret = ohci_suspend(hcd, do_wakeup);
+	if (ret)
+		return ret;
 	if (pdata->power_suspend)
-	return 0;
+	return ret;
 static int ohci_platform_resume(struct device *dev)

More information about the linux-arm-kernel mailing list