[PATCH v2 07/11] ARM:stixxxx: Add STiH416 SOC support

Linus Walleij linus.walleij at linaro.org
Wed Jun 19 14:34:52 EDT 2013


On Mon, Jun 10, 2013 at 3:52 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 10 June 2013 10:27:05 Srinivas KANDAGATLA wrote:
>
>> +     soc {
>> +             pin-controller-sbc {
>> +                     #address-cells  = <1>;
>> +                     #size-cells     = <1>;
>> +                     compatible      = "st,stih416-pinctrl", "simple-bus";
>
> Why is this both its own device with a compatible string and a
> "simple-bus" at the same time? Wouldn't it be simpler to just
> scan the child device nodes from the "st,stih416-pinctrl"
> driver instead of having a separate platform_driver for them?

I think that in my comments to the pinctrl driver I had some
similar comment, so it's probably a good idea to look into
this.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list