[PATCH] ARM: kernel: document ARM CPUs clock-frequency property

Florian Fainelli f.fainelli at gmail.com
Wed Jun 19 06:27:50 EDT 2013


Hello Mark,

2013/6/19 Mark Rutland <mark.rutland at arm.com>:
> On Wed, Jun 19, 2013 at 10:47:17AM +0100, Florian Fainelli wrote:
>> ARM CPU device tree nodes may contain an optional clock-frequency
>> property, when set, this property must contain the CPU frequency in Hz,
>> which is then used by the topology parsing code in
>> arch/arm/kernel/topology.c to infer the CPU capacity.
>
> I see that arch/arm/kernel/topology.c does a pr_err when clock-frequency isn't
> present. If we're documenting it as optional, should we not downgrade that or
> remove it entirely?

Good question. I think it might be good to just dowgrade the error to
a simple warning, we should clearly be fixing the binding if we have a
device_type = "cpu" property but no clock-frequency property.
--
Florian



More information about the linux-arm-kernel mailing list