[PATCH 1/2] serial: sh-sci: HSCIF support

Ulrich Hecht ulrich.hecht at gmail.com
Wed Jun 19 04:46:51 EDT 2013


On Tue, Jun 18, 2013 at 3:19 AM, Simon Horman <horms at verge.net.au> wrote:
>> This hunk causes build warnings in linux-next now:
>>
>> /git/arm-soc/drivers/tty/serial/sh-sci.c: In function 'sci_set_termios':
>> /git/arm-soc/drivers/tty/serial/sh-sci.c:1942:37: warning: 'srr' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     serial_port_out(port, HSSRR, srr | HSCIF_SRE);
>>                                      ^
>> /git/arm-soc/drivers/tty/serial/sh-sci.c:1892:15: note: 'srr' was declared here
>>   unsigned int srr;
>>                ^
>> /git/arm-soc/drivers/tty/serial/sh-sci.c:1938:47: warning: 'cks' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    serial_port_out(port, SCSMR, (smr_val & ~3) | cks);
>>                                                ^
>> /git/arm-soc/drivers/tty/serial/sh-sci.c:1890:40: note: 'cks' was declared here
>>   unsigned int baud, smr_val, max_baud, cks;
>
> Ulrich, could you please look into this?

Hmmm... I get this warning with gcc 4.5, 4.6, and 4.8. Apparently gcc
4.7 is the only one that does not warn about this. Guess what I'm
using... :(

This is of course trivially fixed, but I have completely lost track of
the transmogrifications this patch has been subjected to. What's the
procedure?

CU
Uli



More information about the linux-arm-kernel mailing list