[PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management

Linus Walleij linus.walleij at linaro.org
Mon Jun 17 12:08:51 EDT 2013

On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren <tony at atomide.com> wrote:
> * Linus Walleij <linus.walleij at linaro.org> [130617 04:38]:
>> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja
>> <gururaja.hebbar at ti.com> wrote:
>> > Make pinctrl-single able to handle suspend/resume events and change
>> > hogged pins states accordingly.
>> >
>> > Signed-off-by: Hebbar Gururaja <gururaja.hebbar at ti.com>
>> > Cc: Linus Walleij <linus.walleij at linaro.org>
>> Noone said anything about this patch, but it looks very straight-forward
>> to me and seems sound so I have applied it.
>> If Tony or Haojian has strong feelings about it I will dequeue it.
> I don't like the hogged pins at all as they prevent me from unloading
> pinctrl-single.. But the patch seems fine to me:

Hm? I think the hogged pins are the *only* pins we can
reliably release when unloading the driver, look:

void pinctrl_unregister(struct pinctrl_dev *pctldev)
        if (!IS_ERR(pctldev->p))

That releases all hogged pinctrl handles when unloading
a pinctrl driver.

Linus Walleij

More information about the linux-arm-kernel mailing list