[RFC PATCH 11/11] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

[Linus Walleij]

On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa at gmail.com> wrote:

> This patch adds all required platform-specific data and initialization
> code to support the generic amba-pl08x driver on S3C64xx SoCs.
>
> Also some compatibility definitions are added to make the transition from
> legacy API to DMA engine easier. The biggest hack here is passing const
> char * pointers through DMA resource, casted to unsigned long, but this
> is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine
> in drivers) is designed.
>
> Signed-off-by: Tomasz Figa <tomasz.figa at gmail.com>

Patch looks like an OK stepping stone.

> +static AMBA_AHB_DEVICE(s3c64xx_dma0, "dma-pl080s.0", 0x0a141080,
> +                       0x75000000, {IRQ_DMA0}, &s3c64xx_dma0_plat_data);
(...)
> +static AMBA_AHB_DEVICE(s3c64xx_dma1, "dma-pl080s.1", 0x0a141080,
> +                       0x75100000, {IRQ_DMA1}, &s3c64xx_dma1_plat_data);

Ah, does this mean the device does not have any AMBA PrimeCell ID
contents?

Then use the ID 0x00053080 instead of 0x0a141080

0x53 is "S" for Samsung. Variant 0.

Yours,
Linus Walleij