[PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

Alan Stern stern at rowland.harvard.edu
Mon Jun 17 10:01:23 EDT 2013


On Mon, 17 Jun 2013, Chao Xie wrote:

> > To avoid PHY init/shutdown, the platform driver should simply leave the
> > generic PHY pointer (which has not yet been added to struct hcd) set to
> > NULL.
> >
> So does it mean that i need add adtional usb_phy to struct hcd?

Ah, I was wrong.  There already is a PHY pointer in struct usb_hcd.  
You don't need to add another one.

> I think we can still make use of struct hcd->phy without add addtional members.
> For OMAP transceiver-less mode, you can still use your own phy init/shutdown and
> leave the hcd->phy to be NULL, and for the PHY mode, hcd->phy can be
> set. It will
> do ->init at usb_add_hcd and ->shutdown at usb_remove_hcd.

That's right.

Alan Stern




More information about the linux-arm-kernel mailing list