[PATCH v3 10/10] ARM: Exynos: extend soft-reset support for Exynos5420
Arnd Bergmann
arnd at arndb.de
Mon Jun 17 08:21:49 EDT 2013
On Monday 17 June 2013 16:30:35 Chander Kashyap wrote:
> @@ -330,10 +330,10 @@ void exynos5_restart(char mode, const char *cmd)
> u32 val;
> void __iomem *addr;
>
> - if (of_machine_is_compatible("samsung,exynos5250")) {
> - val = 0x1;
> - addr = EXYNOS_SWRESET;
> - } else if (of_machine_is_compatible("samsung,exynos5440")) {
> + val = 0x1;
> + addr = EXYNOS_SWRESET;
> +
> + if (of_machine_is_compatible("samsung,exynos5440")) {
> u32 status;
> np = of_find_compatible_node(NULL, NULL, "samsung,exynos5440-clock");
>
Please try to avoid adding further uses of hardcoded MMIO addresses.
Can you change that to use the same logic that exynos5440 has?
Arnd
More information about the linux-arm-kernel
mailing list