[PATCH 3/8] ARM: OMAP2+: hwmod: Remove remaining DMA channel definitions

Jarkko Nikula jarkko.nikula at bitmer.com
Sun Jun 16 11:35:13 EDT 2013


Hi Felipe

On 06/15/2013 06:06 PM, Felipe Balbi wrote:
> On Sat, Jun 15, 2013 at 11:31:04AM +0300, Jarkko Nikula wrote:
>> Last remaining DMA channel definitions in arch/arm/mach-omap2/dma.h
>> are used only by omap_hwmod_2xxx_3xxx_ipblock_data.c and
>> omap_hwmod_3xxx_data.c. Remove them by using directly DMA channel number in
>> hwmod data and drop definitions with a following script:
>>
>> egrep '#define [OMAP|AM35XX].*DMA' arch/arm/mach-omap2/dma.h | cut -f 1,3 \
>> 	| while read i; do \
>> 		DEF=`echo $i |cut -d ' ' -f 2`; \
>> 		CH=`echo $i |cut -d ' ' -f 3`; \
>> 		echo "removing" $DEF; \
>> 		sed -i "s/${DEF}/${CH}/" arch/arm/mach-omap2/omap_hwmod_*.c; \
>> 		sed -i "/${DEF}/d" arch/arm/mach-omap2/dma.h; \
>> 	done
>>
>>  /* DMA channels for 24xx */
> 
> could remove the comments too.
> 
You are right. Actually I was thinking that myself too with this and
omap1 patches but decided to keep manual work and scripts bare minimum
and let final git rm in 4/8 and 8/8 to handle these :-)

-- 
Jarkko



More information about the linux-arm-kernel mailing list