[PATCH] ARM: dts: Enable RTC node for exynos5250

Doug Anderson dianders at chromium.org
Fri Jun 14 11:01:09 EDT 2013


Tushar,

On Thu, Jun 13, 2013 at 10:56 PM, Tushar Behera
<tushar.behera at linaro.org> wrote:
> The kernel dump produced by s3c-rtc driver as reported by
> commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5")
> are no longer reproducible in latest kernel.
>
> Hence it would be good to re-enable RTC support for EXYNOS5250.
>
> Signed-off-by: Tushar Behera <tushar.behera at linaro.org>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |    1 -
>  1 file changed, 1 deletion(-)

I would prefer we not commit this.

The original commit wasn't just about avoiding the bug (though that
was a nice side effect).  My understanding is that the SoC dtsi file
ought to have most peripherals disabled by default and individual
board dts files should enable the peripherals that they want.  I think
exynos5250 is particularly bad about this right now (it starts with
most peripherals enabled) but that should probably be fixed...

If my understanding is wrong, others on the list should definitely speak up!  :)

-Doug



More information about the linux-arm-kernel mailing list