[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

Liu Hui-R64343 r64343 at freescale.com
Fri Jun 14 06:02:32 EDT 2013


>-----Original Message-----
>From: Linus Walleij [mailto:linus.walleij at linaro.org]
>Sent: Thursday, June 13, 2013 4:00 PM
>To: Liu Hui-R64343; Mike Turquette
>Cc: linux-arm-kernel at lists.infradead.org; Russell King - ARM Linux
>Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>all online CPUs
>
>On Thu, Jun 13, 2013 at 1:19 AM, Jason Liu <r64343 at freescale.com> wrote:
>
>> When the local timer freq changed, the twd_update_frequency function
>> should be run all the CPUs include itself, otherwise, the twd freq
>> will not get updated and the local timer will not run correcttly.
>>
>> smp_call_function will run functions on all other CPUs, but not
>> include himself, this is not correct,use on_each_cpu instead to fix
>this issue.
>>
>> Signed-off-by: Jason Liu <r64343 at freescale.com>
>> Cc: Russell King <linux at arm.linux.org.uk>
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>> Cc: Rob Herring <rob.herring at calxeda.com>
>> Cc: Shawn Guo <shawn.guo at linaro.org>
>> Cc: Arnd Bergmann <arnd at arndb.de>
>> Cc: stable at vger.kernel.org
>
>Mike Turquette wrote this code, so let him look at it.

Mike, could you please look at it?

>
>But it makes sense to me:
>Acked-by: Linus Walleij <linus.walleij at linaro.org>

Thanks Linus W.

>
>Please mark this for stable and put it into Russell's patch tracker
>after allowing some time for others to have a look.

Sure, Will do it after others look at it. 

>
>Yours,
>Linus Walleij





More information about the linux-arm-kernel mailing list