[PATCH 6/9] ARM: dtsi: imx6qdl-sabresd: Add WM8962 CODEC support

Shawn Guo shawn.guo at linaro.org
Fri Jun 14 02:41:47 EDT 2013


On Fri, Jun 14, 2013 at 02:23:14PM +0800, Nicolin Chen wrote:
> On Fri, Jun 14, 2013 at 02:21:49PM +0800, Shawn Guo wrote:
> > > +
> > > +	codec: wm8962 at 1a {
> > > +		compatible = "wlf,wm8962";
> > > +		reg = <0x1a>;
> > > +		clocks = <&clks 169>;
> > > +		DCVDD-supply = <&reg_audio>;	/* 1.8v */
> > > +		DBVDD-supply = <&reg_audio>;	/* 1.8v */
> > > +		AVDD-supply = <&reg_audio>;	/* 1.8v */
> > > +		CPVDD-supply = <&reg_audio>;	/* 1.8v */
> > > +		MICVDD-supply = <&reg_audio>;	/* 3.3v */
> > > +		PLLVDD-supply = <&reg_audio>;	/* 1.8v */
> > > +		SPKVDD1-supply = <&reg_audio>;	/* 4.2v */
> > > +		SPKVDD2-supply = <&reg_audio>;	/* 4.2v */
> > 
> > You comment these supplies with different voltages but they are actually
> > pointing to the same fixed regulator.
> 
> That's because they are all controlled by one GPIO pin. But you are right
> these comments might be confusing.
> 
> And I think I don't need to send a V2 any more right? Since I saw you said
> you did the fix-up for me.

I just removed the comments.

Shawn




More information about the linux-arm-kernel mailing list