[PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

Linus Walleij linus.walleij at linaro.org
Thu Jun 13 11:36:00 EDT 2013


On Thu, Jun 13, 2013 at 5:23 PM, Heiko Stübner <heiko at sntech.de> wrote:

>> Ok, I'll see that I get this fixed :-)
>
> Hmm ... what is the meaning of the argument of bias-disable and bias-high-
> impedance, as the kernel-doc in pinconf-generic.h does not tell?

I think those arguments are N/A, ignored, doesn't matter.
If these options were typed, they would be bool.

Please improve documentation if you can... sorry for all the
rough edges.

> bias-bus-hold ignores its argument and we already clarified that the pull-* do
> have != 0 or 0 argument.

I think in the DT binding, both these forms:

bias-pull-up;
bias-pull-up = <150000>;

Should be allowed.

So when parsing, you first check if it exists, then if there
is an argument, if there is no value supplied, just set it
to 1, as that is clearly != 0...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list