[PATCH V2 2/2] ARM: decouple CPU offlining from reboot/shutdown
swarren at wwwdotorg.org
Thu Jun 13 11:05:05 EDT 2013
On 06/12/2013 07:58 PM, zhangfei gao wrote:
> On Thu, Jun 13, 2013 at 4:01 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> Hi, Setphen
> We also met the issue: fail to reboot system from panic.
> Solve it by the following change.
> cpu_die is function kill cpu itself
> cpu_kill is functoin to check whethe the cpu is dead or not
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> @@ -554,6 +554,9 @@ static void ipi_cpu_stop(unsigned int cpu)
> +#ifdef CONFIG_HOTPLUG_CPU
> + cpu_die();
> while (1)
> What do you think?
That probably works too, since it pairs cpu_die/cpu_kill, although the
patch I sent ends up running less code during the halt/power_off/restart
path, which seems like a good idea; less stuff to potentially break.
More information about the linux-arm-kernel