[PATCH] thermal: add imx thermal driver support
shawn.guo at linaro.org
Thu Jun 13 00:12:09 EDT 2013
On Thu, Jun 13, 2013 at 11:12:57AM +0800, Zhang Rui wrote:
> On Tue, 2013-06-04 at 15:13 +0800, Shawn Guo wrote:
> > This is based on the initial imx thermal work done by
> > Rob Lee <rob.lee at linaro.org> (Not sure if the email address is still
> > valid). Since he is no longer interested in the work and I have
> > rewritten a significant amount of the code, I just took the authorship
> > over from him.
> > It adds the imx thermal support using Temperature Monitor (TEMPMON)
> > block found on some Freescale i.MX SoCs. The driver uses syscon regmap
> > interface to access TEMPMON control registers and calibration data, and
> > supports cpufreq as the cooling device.
> you're using the cpufrq_cooling to throttle cpus at 85C, right?
> then you should register it as THERMAL_TRIP_PASSIVE instead of
Yes, literally it should be a passive trip point rather than active
one. But I'm not sure if there is any real functional differences
between them in my thermal case, except I have to give both
passive_delay and polling_delay in thermal_zone_device_register()
call for passive type while it only needs polling_delay for active type
to work properly.
Besides, both exynos and db8500 thermal drivers register active trip
point while they are using cpufreq as the cooling device. So I thought
it's fine to not have the trip type literally correct.
More information about the linux-arm-kernel