[PATCH] ARM: dts: Removing pdma for SSDK5440
Sylwester Nawrocki
s.nawrocki at samsung.com
Tue Jun 11 04:49:33 EDT 2013
On 06/11/2013 10:02 AM, Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m at samsung.com>
>
> Since the pdma works only in secure mode, accessing the same
> in hypervisor mode gives an abort. As we are not using pdma
> anywhere (including spi), removing the same.
>
> Signed-off-by: Giridhar Maruthy <giridhar.m at samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
I was wondering, wouldn't it be sufficient to add status = "disabled";
in those pdma nodes, to avoid re-adding them in future ?
As for the DMA properties in the spi device nodes, they should indeed
be removed, as generic DMA bindings would be used instead.
Regards,
Sylwester
> ---
> arch/arm/boot/dts/exynos5440.dtsi | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index 871ebad..b08449e 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -105,8 +105,6 @@
> compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ?
> reg = <0xD0000 0x1000>;
> interrupts = <0 4 0>;
> - tx-dma-channel = <&pdma0 5>; /* preliminary */
> - rx-dma-channel = <&pdma0 4>; /* preliminary */
> #address-cells = <1>;
> #size-cells = <0>;
> clocks = <&clock 21>, <&clock 16>;
> @@ -184,28 +182,6 @@
> compatible = "arm,amba-bus";
> interrupt-parent = <&gic>;
> ranges;
> -
> - pdma0: pdma at 00121000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0x121000 0x1000>;
> - interrupts = <0 46 0>;
> - clocks = <&clock 8>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> -
> - pdma1: pdma at 00120000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0x120000 0x1000>;
> - interrupts = <0 47 0>;
> - clocks = <&clock 8>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> };
More information about the linux-arm-kernel
mailing list