[PATCH 1/9] dma: pl330: rip out broken, redundant ID probing

Will Deacon will.deacon at arm.com
Tue Jun 11 04:45:14 EDT 2013


On Tue, Jun 11, 2013 at 05:40:36AM +0100, Jassi Brar wrote:
> On 11 June 2013 00:04, Will Deacon <will.deacon at arm.com> wrote:
> > The PL330 driver probes the peripheral and primecell IDs of the device to
> > make sure that it is indeed an AMBA PL330. However, it does this by
> > making byte accesses to a device mapping of the word-aligned ID
> > registers, which is either UNPREDICTABLE or generates an alignment fault
> > (depending on the presence of the virtualisation extensions).
> >
> > Rather than fix this code, we can actually rip most of it out and let
> > the AMBA bus driver correctly do the probing for us.
> >
> Acked-by: Jassi Brar <jaswinder.singh at linaro.org>

Thanks for the acks Jassi!

Will



More information about the linux-arm-kernel mailing list