[PATCH 4/8] ARM: vexpress: use generic cpu idle function for wfi

Sanjay Singh Rawat sanjay.rawat at linaro.org
Tue Jun 11 01:33:05 EDT 2013


commit: 8553cb67d2318db327071018fc81084cbabccc46 explains that

-sanjay

On Friday 07 June 2013 08:41 PM, Pawel Moll wrote:
> On Mon, 2013-05-27 at 15:32 +0100, Sanjay Singh Rawat wrote:
>> use cpu_do_idle for entering the wfi mode.
>>
>> Signed-off-by: Sanjay Singh Rawat <sanjay.rawat at linaro.org>
>> ---
>>   arch/arm/mach-vexpress/hotplug.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-vexpress/hotplug.c b/arch/arm/mach-vexpress/hotplug.c
>> index f0ce6b8..b3dffc2 100644
>> --- a/arch/arm/mach-vexpress/hotplug.c
>> +++ b/arch/arm/mach-vexpress/hotplug.c
>> @@ -60,7 +60,8 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
>>   	 * code will have already disabled interrupts
>>   	 */
>>   	for (;;) {
>> -		wfi();
>> +		/* enter WFI mode */
>> +		cpu_do_idle();
>>
>>   		if (pen_release == cpu_logical_map(cpu)) {
>>   			/*
>
> I probably don't get the whole picture, but may I ask what is the
> rationale behind this change? As in: why cpu_do_idle() is better?
>
> Paweł
>
>




More information about the linux-arm-kernel mailing list