[PATCH] reset: provide dummy API entries to avoid link errors

Barry Song 21cnbao at gmail.com
Mon Jun 10 21:39:31 EDT 2013


2013/6/11 Stephen Warren <swarren at wwwdotorg.org>:
> On 06/08/2013 11:30 PM, Barry Song wrote:
>> this patch provides dummy reset API entries like other subsystem e.g.
>> gpiolib to avoid link errors when RESET_CONTROLLER is not enabled.
>
> I would tend to think that any driver that needs to use this API to
> reset its HW should depend on the reset API (or select it) to ensure
> that the API was present.
>
> That way, problems would be detected at compile-time, not run-time.

Hi Stephen,
your point is right if the hardware IP always need a real reset to
work. but the current situation is that many common IP can be used in
many chips. in some chips, the designer might provide a reset
controller with a bit set to reset this IP module, but in some other
chips, there can be no. so a common driver for this IP should be able
to work with calling device_reset even while lacking of
RESET_CONTROLLER. here we are considering a case for chipidea,
ci13xxx, there is a reset bit for it on sirf, but it seems these is no
code showing a reset bit exists for imx.

>

-barry



More information about the linux-arm-kernel mailing list