[PATCH 00/21] ARM: ux500: Enable Clock look-up from Device Tree

Ulf Hansson ulf.hansson at linaro.org
Mon Jun 10 17:05:08 EDT 2013


On 3 June 2013 15:42, Lee Jones <lee.jones at linaro.org> wrote:
> Nice and simple implementation using standard Clk APIs.
Hi Lee,

I may be a bit tired, but I am having a bit hard to follow the steps
taken in this patch set. :-)

I should of course tell you why:
1. You start out by adding DT definitions in the DT files, should that
not be done as the final step, after the DT support has been added in
ux500 clk driver?
2. Moreover, I think it would be enough to group the definitions
patches into one patch or at least significant fewer. Same feeling
about the patches were you remove the AUXDATA, this would simplify the
review for me.
3. The rest will be commented per patch.

Kind regards
Ulf Hansson

>
>  arch/arm/boot/dts/dbx5x0.dtsi    |   94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  arch/arm/boot/dts/snowball.dts   |    3 ++-
>  arch/arm/mach-ux500/cpu-db8500.c |   36 +--------------------------
>  drivers/clk/ux500/u8500_clk.c    |  154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  4 files changed, 249 insertions(+), 38 deletions(-)
>
>



More information about the linux-arm-kernel mailing list