[PATCH] serial: imx: enable the clocks for console

Fabio Estevam festevam at gmail.com
Sat Jun 8 09:11:07 EDT 2013


Hi Huang,

On Sat, Jun 8, 2013 at 5:04 AM, Huang Shijie <b32955 at freescale.com> wrote:

> +       if (!uart_console(port)) {
> +               retval = clk_prepare_enable(sport->clk_per);
> +               if (retval)
> +                       goto error_out1;
> +               retval = clk_prepare_enable(sport->clk_ipg);
> +               if (retval)
> +                       goto error_out1;

Here you should not jump to "error_out1".

You should jump to a different label and disable the sport->clk_per clock.

This was also wrong in your previous patch.



More information about the linux-arm-kernel mailing list