[RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 a separate driver

Arnd Bergmann arnd at arndb.de
Fri Jun 7 09:56:08 EDT 2013


On Friday 07 June 2013 11:33:33 Manjunath Goudar wrote:
> 
> +       ohci_setup(hcd);
>         s3c2410_start_hc(dev, hcd);
>  
> -       ohci_hcd_init(hcd_to_ohci(hcd));
> -

I'm not sure about this part: s3c2410_start_hc is where the clock gets
enabled, presumable we are not supposed to touch the ohci registers
before it gets called, so ohci_init() being called implicitly
by ohci_setup() seems like a bad idea.

	Arnd



More information about the linux-arm-kernel mailing list