[PATCH v2 3/6] clk: divider: add CLK_DIVIDER_HIWORD_MASK flag

Linus Walleij linus.walleij at linaro.org
Fri Jun 7 05:15:38 EDT 2013


On Tue, Jun 4, 2013 at 5:05 PM, Haojian Zhuang
<haojian.zhuang at linaro.org> wrote:

> In Hisilicon Hi3620 clock divider register, 16-bit HIWORD is mask field.
> Support the HIWORD mask to reuse clock divider driver.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>

I don't understand this...

> + * CLK_DIVIDER_HIWORD_MASK - register contains high 16-bit as mask field

Could you be a bit more verbose here on what this actually means,
so other users of this flag will realize if they need to set it?

In other cases in the clk subsystem where masks and shifts are
used, the position and number of bits are stated, rather than a
single flag indicating some 16 bits.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list