[PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips

Arnd Bergmann arnd at arndb.de
Wed Jun 5 07:36:49 EDT 2013


On Wednesday 05 June 2013, Alexander Shiyan wrote:
> Well, let's leave the kconfig symbol as is. But about the rest, that mc13783_*
> symbols in the log (debug) will say a developer who does not know about
> mc13892 compatibility with mc13783? I still believe that this should be reflected.

If the log messages use dev_printk, they will use the correct device name already,
if not, that can be fixed.

I agree with Jean: we don't just rename things unless there is a significant
benefit, which I don't see here. There is also the risk that we need to support
a different chip named mc13xxx in the future that is different enough to require
a new driver and then the naming is even more screwed up.

	Arnd



More information about the linux-arm-kernel mailing list