[PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Jun 4 20:17:56 EDT 2013


Hi

> > Could you please teach me who/how/when free resource memory
> > which was kmemdup'ed by platform_device_add_xxx()
> > (and kmalloc'ed dma_mask) on platform_device_register_full() ??
> 
>     I don't think there's a need to free them. The EHCI/OHCI devices
> are always there after all.

Yes, you are correct.
Many devices are existing in Renesas chip, not only EHCI/OHCI.

But in r8a7778 case, these ehci/ohci doesn't work if usb-phy wasn't enabled,
and without PFC settings from platform.


> >>     I just copied your approach from the R8A7779 code.
> 
> > Ahh, yes, indeed
> 
>      Moreover, from our prior testing, I'm afraid registering USB PHY 
> and EHCI/OHCI in one function wouldn't work. Unless maybe if it's done 
> from the init_late() machine's method...

I'm sorry.
This mention (= phy and ohci/ehci registration in one function) was my fault.
Your style is correct I think.

Best regards
---
Kuninori Morimoto



More information about the linux-arm-kernel mailing list