[PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

Linus Walleij linus.walleij at linaro.org
Tue Jun 4 05:14:16 EDT 2013

On Thu, May 30, 2013 at 7:33 PM, Vinod Koul <vinod.koul at intel.com> wrote:
> On Thu, May 30, 2013 at 09:41:38AM +0200, Linus Walleij wrote:
>> On Thu, May 30, 2013 at 6:32 AM, Wei Yongjun <weiyj.lk at gmail.com> wrote:
>> > From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>> >
>> > In many of the error handling case, the return value 'ret' not set
>> > and 0 will be return from d40_probe() even if error, but we should
>> > return a negative error code instead in those error handling case.
>> > This patch fixed them, and also removed useless variable 'err'.
>> >
>> > Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>> > ---
>> > v1 -> v2: rebased on linux-next.git
>> I've tentatively applied this to my dma40 branch, waiting for Vinod
>> to ACK it.
> I though you wanted me to apply this :)
> Nevertheless, Acked-by: Vinod Koul <vinod.koul at intel.com>
> Can you CC stable too, pls.

Hm I'm not sending any DMA40 stuff for stable, sorry ...
if you want it to go into stable you'd better pick this
(the v3 version) into the DMA tree.

Let me know how you want it, I've removed it from my
dma40 branch for the time being.

Linus Walleij

More information about the linux-arm-kernel mailing list